[U-Boot] lcd_putc bug?

Derek Ou derek at siconix.com
Tue Feb 3 19:44:06 CET 2009


In the lcd_putc() of common/lcd.c, line 189 handles tab '\t'.  And the 
following lines:
            console_col |=  8;
            console_col &= ~7;
seems to have problems.  If console_col is 9, it will become 8 after the 
above two lines, which means instead of tab of 8 spaces, it goes back 
1.  Is this intentional or a bug?

I think it should be console_col +=  8; instead of console_col |=  8;

Derek


More information about the U-Boot mailing list