[U-Boot] [PATCH 8/9] video: add a i.MX31 framebuffer driver only for bitmaps so far

[Magnus Lilja]

Hi

2009/2/4 Guennadi Liakhovetski <lg at denx.de>:
> On Wed, 4 Feb 2009, Magnus Lilja wrote:
>
>> > +       switch (channel) {
>> > +       case IDMAC_SDC_0:
>> > +               ipu_channel_set_priority(channel, 1);
>>
>> Missing break?
>
> You don't mean inserting a break here would change anything, do you?

Not in this code but when the next developer adds a case
IDMAC_MMM_NNN: after the existing case it's easy to forget to add that
missing break.

>
>> > +       default:
>> > +               break;
>> > +       }
>
> [snip]
>
>> > +/* References in this function refer to respective Linux kernel sources */
>> > +void lcd_enable (void)
>> > +{
>> > +       u32 reg;
>> > +
>> > +       /* pcm037.c::mxc_board_init() */
>>
>> Strance comment in a generic file.
>
> "Strance"? See just 5 lines above.

Ok, I missed that comment. ("Strance" => "Strange")


Thanks, Magnus