[U-Boot] [PATCH 8/9] video: add a i.MX31 framebuffer driver only for bitmaps so far

[Wolfgang Denk]

Dear Guennadi Liakhovetski,

In message <Pine.LNX.4.64.0902042031420.6279 at axis700.grange> you wrote:
> On Wed, 4 Feb 2009, Magnus Lilja wrote:
> 
> > > +       switch (channel) {
> > > +       case IDMAC_SDC_0:
> > > +               ipu_channel_set_priority(channel, 1);
> > 
> > Missing break?
> 
> You don't mean inserting a break here would change anything, do you?

Yes, it would change the code considerably: it would make clear what
the intentions of the programmer were.

Please do what has been asked for.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The use of COBOL cripples the mind; its teaching  should,  therefore,
be regarded as a criminal offence.
          -- Edsger W. Dijkstra, SIGPLAN Notices, Volume 17, Number 5