[U-Boot] [PATCH 18/42] Blackfin: make sure autoconf.mk is generated early enough

[Wolfgang Denk]

Dear Mike Frysinger,

In message <200902101357.29507.vapier at gentoo.org> you wrote:
>
> > >  $(BFIN_BOARDS:%=%_config)	: unconfig
> > >  	@$(MKCONFIG) $(@:_config=) blackfin blackfin $(@:_config=)
> > > +	@$(MAKE) -s -B $(obj)include/autoconf.mk
> > > +	@$(MAKE) -s -B $(obj)include/autoconf.mk
> >
> > Do you really mean to do this twice?
>
> unfortunately, yes.  since some settings in the board config are turned into 
> compiler flags and those compiler flags can in turn affect the board config, 
> we need to do it twice.  first is to make sure the proper cpu flags are 
> propagated into the toplevel build env while the second is to make sure the  
> autoconf.mk fully reflects the board config.

Sounds like a design problem to me.

> i guess i could add a one line comment above each one giving hints about why 
> each is needed ...

That would be the minimum, but given the  fact  that  the  top  level
Makefile  already includes rules to build autoconf.mk I really wonder
if we must do this so often, and if so, then why  this  is  only  the
case for blackfin.


I think you should fix the cuase rather then doctor about the
symptoms.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The joys of love made her human and the  agonies  of  love  destroyed
her.
	-- Spock, "Requiem for Methuselah", stardate 5842.8