[U-Boot] [PATCH] 3/12 Multiadapter/multibus I2C, boards
Wolfgang Denk
wd at denx.de
Mon Feb 16 22:44:22 CET 2009
Dear ksi at koi8.net,
In message <Pine.LNX.4.64ksi.0902121413560.21067 at home-gw.koi8.net> you wrote:
>
...
> - if (eeprom_read (dev_addr, 0, i2c_buffer, CONFIG_SYS_IVM_EEPROM_MAX_LEN) != 0) {
> - printf ("Error reading EEprom\n");
> - return -2;
> + if (eeprom_read (tmp, 0, i2c_buffer, CONFIG_SYS_IVM_EEPROM_MAX_LEN) != 0) {
^^ space kept
> + printf("Error reading EEprom\n");
^^ space deleted.
> + return(-2);
Please do not mix coding style changes with functional changes in one
patch. And please do not change style at random - leaving spaces here
but removing them there. At least use a consistent style.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The price one pays for pursuing any profession, or calling, is an
intimate knowledge of its ugly side. - James Baldwin
More information about the U-Boot
mailing list