[U-Boot] [PATCH] 3/12 Multiadapter/multibus I2C, boards
ksi at koi8.net
ksi at koi8.net
Tue Feb 17 19:36:14 CET 2009
On Mon, 16 Feb 2009, Wolfgang Denk wrote:
> Dear ksi at koi8.net,
>
> In message <Pine.LNX.4.64ksi.0902121413560.21067 at home-gw.koi8.net> you wrote:
> >
> ...
> > - if (eeprom_read (dev_addr, 0, i2c_buffer, CONFIG_SYS_IVM_EEPROM_MAX_LEN) != 0) {
> > - printf ("Error reading EEprom\n");
> > - return -2;
> > + if (eeprom_read (tmp, 0, i2c_buffer, CONFIG_SYS_IVM_EEPROM_MAX_LEN) != 0) {
> ^^ space kept
> > + printf("Error reading EEprom\n");
> ^^ space deleted.
> > + return(-2);
>
> Please do not mix coding style changes with functional changes in one
> patch. And please do not change style at random - leaving spaces here
> but removing them there. At least use a consistent style.
OK, I won't touch those.
---
******************************************************************
* KSI at home KOI8 Net < > The impossible we do immediately. *
* Las Vegas NV, USA < > Miracles require 24-hour notice. *
******************************************************************
More information about the U-Boot
mailing list