[U-Boot] [PATCH] mkconfig: include board config.h before asm/config.h

Kim Phillips kim.phillips at freescale.com
Thu Feb 19 00:09:57 CET 2009


On Wed, 18 Feb 2009 23:15:52 +0100
Wolfgang Denk <wd at denx.de> wrote:

> Dear Kim Phillips,
> 
> In message <20090218161429.d2a02a7b.kim.phillips at freescale.com> you wrote:
> > swapping the include order suppresses warnings for board configs
> > that define their own CONFIG_MAX_MEM_MAPPED:
> ...
> >  echo "/* Automatically generated - do not edit */" >>config.h
> > -echo "#include <asm/config.h>" >>config.h
> >  echo "#include <configs/$1.h>" >>config.h
> > +echo "#include <asm/config.h>" >>config.h
> 
> That's a pretty big hammer that affects ALL boards.
> 
> Are you absolutely sure it has no negative side effects?

unfortunately I don't have a supercomputer over here, so I can't be
100% sure.  I did however check samples from 4xx, 83xx, 85xx, and 86xx
- due to recent relevant chatter wrt those platforms.

The alternative is to search for a better home for
CONFIG_MAX_MEM_MAPPED's default definition.

Kim


More information about the U-Boot mailing list