[U-Boot] [PATCH] mkconfig: include board config.h before asm/config.h
Wolfgang Denk
wd at denx.de
Thu Feb 19 00:22:33 CET 2009
Dear Kim Phillips,
In message <20090218170957.5013c73d.kim.phillips at freescale.com> you wrote:
>
> > > -echo "#include <asm/config.h>" >>config.h
> > > echo "#include <configs/$1.h>" >>config.h
> > > +echo "#include <asm/config.h>" >>config.h
> >
> > That's a pretty big hammer that affects ALL boards.
> >
> > Are you absolutely sure it has no negative side effects?
>
> unfortunately I don't have a supercomputer over here, so I can't be
> 100% sure. I did however check samples from 4xx, 83xx, 85xx, and 86xx
> - due to recent relevant chatter wrt those platforms.
Well, I needed some time to realize that the
echo "#include <asm/config.h>" >>config.h
part is actually pretty new anyway - coming from commit 47d41cc3 less
than two weeks ago. So your patch is indeed harmless.
> The alternative is to search for a better home for
> CONFIG_MAX_MEM_MAPPED's default definition.
For now I will apply your patch. Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You can observe a lot just by watchin'. - Yogi Berra
More information about the U-Boot
mailing list