[U-Boot] CONFIG_SYS_HZ: Please revert breaking net commit

[Detlef Vollmann]

Hello,

 From CHANGELOG:
<quote>
commit 49f3bdbba8071f56d950a9498b6cdb998b35340a
Author: Bartlomiej Sieka <tur at semihalf.com>
Date:   Wed Oct 1 15:26:28 2008 +0200

     net: express the first argument to NetSetTimeout() in milliseconds

     Enforce millisecond semantics of the first argument to 
NetSetTimeout() --
     the change is transparent for well-behaving boards (CFG_HZ == 1000 and
     get_timer() countiing in milliseconds).

     Rationale for this patch is to enable millisecond granularity for
     network-related timeouts, which is needed for the upcoming automatic
     software update feature.

     Summary of changes:
     - do not scale the first argument to NetSetTimeout() by CFG_HZ
     - change timeout values used in the networking code to milliseconds

     Signed-off-by: Rafal Czubak <rcz at semihalf.com>
     Signed-off-by: Bartlomiej Sieka <tur at semihalf.com>
     Signed-off-by: Ben Warren <biggerbadderben at gmail.com>
</quote>

This commit breaks *silently* all boards that don't return
milliseconds from get_timer, i.e. have a different value for
CONFIG_SYS_HZ than 1000.
I'm open to any discussion about removing CONFIG_SYS_HZ, but
if it is removed, it should be removed explicitely, and not
just silently ignored.

So I see following reasons to revert the above commit:
  - silently breaks existing boards
  - silently ignores a still valid CONFIG setting
  - bad programming style anyway: even if CONFIG_SYS_HZ would
    go away, there should be some internal define that should
    be used in code
  - the intended benefit 'millisecond granularity for network-related
    timeouts' can be achieved while still keeping CONFIG_SYS_HZ

Best Regards,
   Detlef

-- 
Detlef Vollmann   vollmann engineering gmbh
Linux and C++ for Embedded Systems    http://www.vollmann.ch/