[U-Boot] [PATCH 1/1] arm: fix some arch_number definition

[Wolfgang Denk]

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20090122111348.GC22829 at game.jcrosoft.org> you wrote:
>
> > > > "board/lpc2292sodimm/lpc2292sodimm.c":
> > > > 
> > > >  42         /* arch number MACH_TYPE_ARMADILLO - not official*/
> > > >  43         gd->bd->bi_arch_number = 83;
> > > I've not find it in the official list so I've let as 83 (non registered board)
> > 
> > You canged the old "MACH_TYPE_ARMADILLO" / 83 setting in one place but
> > not in others? This will cause inconsistent behaviour.
> > 
> > You must not do that.  Either leave ALL of these as they are, or fix
> > ALL of them in the SAME way.
> the other board are not a ARMODILLO correct if I wrong

I don't know, and frankly, I don't care.

If you implement such a change, you must at least implement it
consistently.

If you don't know how to do that for a specific board, then you need
to talk with the board maintainers.

Fixing the problm in one place but leaving it unfixed in some other
places (knowingly) is not acceptable.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Disc space - the final frontier!