[U-Boot] [PATCH 1/1] arm: fix some arch_number definition

[Detlev Zundel]

Hi Jean-Christophe,

>> > > Note that there are other places where this is used - these must be
>> > > changed, too - for example:
>> > > 
>> > > "board/lpc2292sodimm/lpc2292sodimm.c":
>> > > 
>> > >  42         /* arch number MACH_TYPE_ARMADILLO - not official*/
>> > >  43         gd->bd->bi_arch_number = 83;
>> > I've not find it in the official list so I've let as 83 (non registered board)
>> 
>> You canged the old "MACH_TYPE_ARMADILLO" / 83 setting in one place but
>> not in others? This will cause inconsistent behaviour.
>> 
>> You must not do that.  Either leave ALL of these as they are, or fix
>> ALL of them in the SAME way.
> the other board are not a ARMODILLO correct if I wrong

Why not correct the wrong comment?  I think this is the consistent thing
to do, as there certainly is no definition for "83" in the kernel and 83
has nothing to do with ARMADILLO.

Cheers
  Detlev

PS: You have an interesting Mail-Followup-To on this posting.  Maybe I
    should do this also to cut down on my incoming mails ;)

-- 
Two  monks went  fishing in an  electron river.  The first monk drew out his
network, and out flopped a hacker.  The second monk cried, "The poor hacker!
How can  it live outside of the  network?"   The first monk said,  "When you
have learned to live outside the network, then you will know."
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de