[U-Boot] [PATCH] Remove static type from gunzip_bmp()
Wolfgang Denk
wd at denx.de
Tue Jan 27 11:57:13 CET 2009
Dear Mark Jackson,
In message <497EE024.9040800 at mimc.co.uk> you wrote:
> THe current bmp routines support gzipped files, but compilation fails due to
> the gunzip_bmp() function being defined as static.
I cannot confirm that. There are boards that use this feature, and
they build fine.
> This patch fixes this problem.
>
> Signed-off-by: Mark Jackson <mpfj at mimc.co.uk>
> ---
> common/cmd_bmp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/common/cmd_bmp.c b/common/cmd_bmp.c
> index bc08b26..2104e59 100644
> --- a/common/cmd_bmp.c
> +++ b/common/cmd_bmp.c
> @@ -46,7 +46,7 @@ int gunzip(void *, int, unsigned char *, unsigned long *);
> * didn't contain a valid BMP signature.
> */
> #ifdef CONFIG_VIDEO_BMP_GZIP
> -static bmp_image_t *gunzip_bmp(unsigned long addr, unsigned long *lenp)
> +bmp_image_t *gunzip_bmp(unsigned long addr, unsigned long *lenp)
There is another ocurrence of "static bmp_image_t *gunzip_bmp()" in
this file - you change one and leave the other unchanged.
If you change this, please change both places so they stay in sync,
and add a proper prototype declaration to the header file.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"A child is a person who can't understand why someone would give away
a perfectly good kitten." - Doug Larson
More information about the U-Boot
mailing list