No subject
Fri Jan 23 11:48:37 CET 2009
loaded by coreboot on the chromebook, and it's likely that other coreboot
motherboards may want to do the same. Therefore can you change:
board/chromebook-x86/coreboot
to:
board/coreboot/chromebook-x86/
Regarding the empty functions, I know they are required to keep the linker
happy. I see two options:
1) #ifdef the call sites
2) create weak stubs
I'm open to debate on the preferred approach
Regards,
Graeme
>
> Gabe
>
> On Fri, Nov 4, 2011 at 3:24 PM, Mike Frysinger <vapier at gentoo.org
> <mailto:vapier at gentoo.org>> wrote:
>
> i'm not terribly familiar with what it takes to make an x86 board, but
> i don't
> see anything jumping out of this patch.
>
> i would note however that you should merge the boards.cfg update into this
> patch. merging one or the other doesn't make much sense, and there's no
> reason to keep them split.
>
> > +void setup_pcat_compatibility()
>
> should be "(void)"
> -mike
>
>
More information about the U-Boot
mailing list