[U-Boot] [PATCH v2 12/12] 83xx: Add support for fsl_dma driver

Peter Tyser ptyser at xes-inc.com
Wed Jul 8 16:13:49 CEST 2009


Hi Stefan,

> > +++ b/include/asm-ppc/config.h
> > @@ -30,8 +30,9 @@
> >  #endif
> >
> >  #ifndef CONFIG_FSL_DMA
> > -#if defined(CONFIG_DDR_ECC) && !defined(CONFIG_ECC_INIT_VIA_DDRCONTROLLER)
> > && \ -	(defined(CONFIG_MPC85xx) || defined(CONFIG_MPC86xx))
> > +#if ((!defined CONFIG_MPC83xx && defined(CONFIG_DDR_ECC) &&	\
> > +	!defined(CONFIG_ECC_INIT_VIA_DDRCONTROLLER)) ||		\
> > +	(defined(CONFIG_MPC83xx) && defined(CONFIG_DDR_ECC_INIT_VIA_DMA)))
> >  #define CONFIG_FSL_DMA
> >  #endif
> >  #endif
> 
> The #if construct doesn't seem to work for all PPC boards. I have to admit 
> that I don't understand the logic enabling the CONFIG_FSL_DMA define. It would 
> be great if you (or somebody else with the FSL insight) could fix this.

Thanks for the catch.  I'll send a cleanup patch shortly.

Peter



More information about the U-Boot mailing list