[U-Boot] [PATCH v2 12/12] 83xx: Add support for fsl_dma driver

Ira Snyder iws at ovro.caltech.edu
Wed Jul 8 17:24:51 CEST 2009


On Wed, Jul 08, 2009 at 09:30:01AM -0500, Peter Tyser wrote:
> On Wed, 2009-07-08 at 09:07 -0500, Kumar Gala wrote:
> > Peter,
> > 
> > Also, I'm not seeing anyone defining CONFIG_DDR_ECC_INIT_VIA_DMA for  
> > 83xx.  I don't see any reason not to use DMA on 83xx.
> 
> When I submitted the original patch I didn't see any 83xx boards using
> either CONFIG_ECC_INIT_VIA_DDRCONTROLLER or CONFIG_DDR_ECC_INIT_VIA_DMA.
> It didn't look like the 83xx platform supported the
> CONFIG_ECC_INIT_VIA_DDRCONTROLLER option at all, although some 83xx
> boards make reference to !CONFIG_DDR_ECC_INIT_VIA_DMA.
> 
> I don't have any 83xx boards to test on and am not that familiar with
> the 83xx so I didn't look into fixing the inconsistencies.  In a perfect
> world CONFIG_ECC_INIT_VIA_DDRCONTROLLER would be enabled for all 83xx
> cpus that supported it, and the DMA init would be the default.
> 
> I'd be happy to send a patch to change the 83xx arch to use DMA to
> initialize ECC when !CONFIG_ECC_INIT_VIA_DDRCONTROLLER if someone else
> will test.  Do all 83xx CPUs have the Elo DMA controller DMA engine?
> 

I'm always happy to test anything on an mpc8349emds.

I don't have any ECC RAM for my mpc8349emds board, but I do have a
custom 8349ea-based board with ECC RAM. The U-Boot port is just a
trimmed down copy of the mpc8349emds port, so I can test with that.

Ira


More information about the U-Boot mailing list