[U-Boot] [PATCH 4/4] arm/kirkwood: Add Keymile SUEN3 support

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Sun Jul 12 17:41:15 CEST 2009


On 09:15 Thu 09 Jul     , Stefan Roese wrote:
> Hi Prafulla,
> 
> On Wednesday 08 July 2009 19:48:19 Prafulla Wadaskar wrote:
> > >  MAINTAINERS                       |    1 +
> > >  MAKEALL                           |    1 +
> > >  Makefile                          |    3 +
> > >  board/keymile/suen3/Makefile      |   51 +++++++++
> > >  board/keymile/suen3/config.mk     |   25 ++++
> > >  board/keymile/suen3/sdramregs.txt |   28 +++++
> >
> > This file will be of no use until we have proposed bin_dep.sh and doimage
> > utility in place.
> 
> Even without doimage and/or bin_dep.sh in place, I think it makes perfect 
> sense to include this SDRAM init file in the board directory. Mainly because 
> of two reasons:
> 
> a) Keep bootloader related files in one place (SDRAM init is crucial for
>    correct operation)
> 
> b) Keep those files under revision control
> 
> And I don't think that anything really speaks against having this file in this 
> place for now.
> 
> But anyway, we should try to get at least your bin_dep.sh infrastructure 
> accepter. Or at least restart the discussion about it (and probably about 
> doimage as well).
I do not think we need this bin_dep.sh at all

we can simply add a new target
u-boot.kwd
which will do somthing like this

$(obj)u-boot.kwd:	$(obj)u-boot.bin
	$(do_image) $(obj)u-boot.kwd $(obj)u-boot.bin $(obj)board/$(BOARDDIR)/sdramregs.txt

Best Regards,
J.


More information about the U-Boot mailing list