[U-Boot] [PATCH 4/4] arm/kirkwood: Add Keymile SUEN3 support

[Prafulla Wadaskar]

> -----Original Message-----
> From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com] 
> Sent: Sunday, July 12, 2009 9:11 PM
> To: Stefan Roese
> Cc: Prafulla Wadaskar; u-boot at lists.denx.de; Ashish Karkare; 
> Prabhanjan Sarnaik
> Subject: Re: [U-Boot] [PATCH 4/4] arm/kirkwood: Add Keymile 
> SUEN3 support
> 
> On 09:15 Thu 09 Jul     , Stefan Roese wrote:
> > Hi Prafulla,
> > 
> > On Wednesday 08 July 2009 19:48:19 Prafulla Wadaskar wrote:
> > > >  MAINTAINERS                       |    1 +
> > > >  MAKEALL                           |    1 +
> > > >  Makefile                          |    3 +
> > > >  board/keymile/suen3/Makefile      |   51 +++++++++
> > > >  board/keymile/suen3/config.mk     |   25 ++++
> > > >  board/keymile/suen3/sdramregs.txt |   28 +++++
> > >
> > > This file will be of no use until we have proposed bin_dep.sh and 
> > > doimage utility in place.
> > 
> > Even without doimage and/or bin_dep.sh in place, I think it makes 
> > perfect sense to include this SDRAM init file in the board 
> directory. 
> > Mainly because of two reasons:
> > 
> > a) Keep bootloader related files in one place (SDRAM init 
> is crucial for
> >    correct operation)
> > 
> > b) Keep those files under revision control
> > 
> > And I don't think that anything really speaks against 
> having this file 
> > in this place for now.
> > 
> > But anyway, we should try to get at least your bin_dep.sh 
> > infrastructure accepter. Or at least restart the discussion 
> about it 
> > (and probably about doimage as well).
> I do not think we need this bin_dep.sh at all
> 
> we can simply add a new target
> u-boot.kwd
> which will do somthing like this
> 
> $(obj)u-boot.kwd:	$(obj)u-boot.bin
> 	$(do_image) $(obj)u-boot.kwd $(obj)u-boot.bin 
> $(obj)board/$(BOARDDIR)/sdramregs.txt

Dear Jean
Your suggestion is good and simple to implement
But this change is Arch/Soc specific 
like Kirkwood for other new comer SOCs if required we will end up adding such support.
there are some other already supported targets which need similar support but done in the way that you have suggested

Why not to provide some automation to take care of such activities?

Bin_dep.sh provides the same, once it is there it will be easier to handle any u-boot.bin post processing in board/arch/Soc specific folders (even we can append tools too).

I wonder why I need to modify root Makefile to support new board?
Even this can be automated to put relevant boards configuration to respective soc/Arch folder 

I am reposting this patch

Regards..
Prafulla . .
 
> 
> Best Regards,
> J.
>