[U-Boot] [PATCH 4/4] arm/kirkwood: Add Keymile SUEN3 support

Wolfgang Denk wd at denx.de
Mon Jul 13 13:23:53 CEST 2009


Dear Prafulla Wadaskar,

In message <73173D32E9439E4ABB5151606C3E19E202DDF2694F at SC-VEXCH1.marvell.com> you wrote:
>  
> > we can simply add a new target
> > u-boot.kwd
> > which will do somthing like this
> > 
> > $(obj)u-boot.kwd:	$(obj)u-boot.bin
> > 	$(do_image) $(obj)u-boot.kwd $(obj)u-boot.bin 
> > $(obj)board/$(BOARDDIR)/sdramregs.txt

Note: "do_image" is way to generic; please use a more specific name.

> Your suggestion is good and simple to implement
> But this change is Arch/Soc specific 
> like Kirkwood for other new comer SOCs if required we will end up adding such support.
> there are some other already supported targets which need similar support but done in the way that you have suggested
> 
> Why not to provide some automation to take care of such activities?

I'm not sure what you mean by "automation". Please elucidate.

> Bin_dep.sh provides the same, once it is there it will be easier to handle any u-boot.bin post processing in board/arch/Soc specific folders (even we can append tools too).

The U-Boot build process is controlled by the top level Makefile,  so
when  you  need an additional step to warp the standard U-Boot binary
image (u-boot.bin) into a new, custom image  format  (u-boot.kwd  ?),
you  will have to add a rule for that int he top level Makefile, plus
provide the required scripts / tools (note that these may or may  not
be included with the U-Boot source tree).

> I wonder why I need to modify root Makefile to support new board?

We are not talking about adding a new board, but about adding a new
image format.

> Even this can be automated to put relevant boards configuration to respective soc/Arch folder 

I don't understand what you mean.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You have the capacity to learn from  mistakes.  You'll  learn  a  lot
today.


More information about the U-Boot mailing list