[U-Boot] [PATCH v6 2/2] Marvell Sheevaplug Board support

[Wolfgang Denk]

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20090712151534.GF7218 at game.jcrosoft.org> you wrote:
>
> > > > +#undef CONFIG_CMD_FLASH
> > > > +#define CONFIG_SYS_NO_FLASH		/* Declare no flash (NOR/SPI) */
> > > please move this 2
> > > > +
> > > > +#include <config_cmd_default.h>
> > > > +#define CONFIG_CMD_AUTOSCRIPT
> > > > +#define CONFIG_CMD_DHCP
> > > > +#define CONFIG_CMD_ENV
> > > > +#define CONFIG_CMD_FAT
> > > > +#define CONFIG_CMD_NAND
> > > > +#define CONFIG_CMD_PING
> > > > +#define CONFIG_CMD_USB
> > > here
> > 
> > Why?
> how this suppose to work?
> you undef the CMD_FLASH et redefine it from the default?

Good. It would be nice if you added such an explanation to your
comment, so people understand why you are making such requests.
Otherwise they might assume you just had to make any comment.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
       There is enough for the need of everyone in this world,
       but not for the greed of everyone.     - Mahatma Gandhi