[U-Boot] [PATCH v6 2/2] Marvell Sheevaplug Board support

[Jean-Christophe PLAGNIOL-VILLARD]

On 17:54 Sun 12 Jul     , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
> 
> In message <20090712151534.GF7218 at game.jcrosoft.org> you wrote:
> >
> > > > > +#undef CONFIG_CMD_FLASH
> > > > > +#define CONFIG_SYS_NO_FLASH		/* Declare no flash (NOR/SPI) */
> > > > please move this 2
> > > > > +
> > > > > +#include <config_cmd_default.h>
> > > > > +#define CONFIG_CMD_AUTOSCRIPT
> > > > > +#define CONFIG_CMD_DHCP
> > > > > +#define CONFIG_CMD_ENV
> > > > > +#define CONFIG_CMD_FAT
> > > > > +#define CONFIG_CMD_NAND
> > > > > +#define CONFIG_CMD_PING
> > > > > +#define CONFIG_CMD_USB
> > > > here
> > > 
> > > Why?
> > how this suppose to work?
> > you undef the CMD_FLASH et redefine it from the default?
> 
> Good. It would be nice if you added such an explanation to your
> comment, so people understand why you are making such requests.
> Otherwise they might assume you just had to make any comment.
ok it was too obvious for me

Best Regards,
J.