[U-Boot] [PATCH v6 2/2] Marvell Sheevaplug Board support

[Prafulla Wadaskar]

> -----Original Message-----
> From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com] 
> Sent: Sunday, July 12, 2009 9:37 PM
> To: Wolfgang Denk
> Cc: Prafulla Wadaskar; Manas Saksena; Ronen Shitrit; Nicolas 
> Pitre; u-boot at lists.denx.de; Ashish Karkare; Prabhanjan 
> Sarnaik; Lennert Buijtenhek
> Subject: Re: [U-Boot] [PATCH v6 2/2] Marvell Sheevaplug Board support
> 
> On 17:54 Sun 12 Jul     , Wolfgang Denk wrote:
> > Dear Jean-Christophe PLAGNIOL-VILLARD,
> > 
> > In message <20090712151534.GF7218 at game.jcrosoft.org> you wrote:
> > >
> > > > > > +#undef CONFIG_CMD_FLASH
Dear Jean
I can define this line below
> > > > > > +#define CONFIG_SYS_NO_FLASH		/* 
But I can't define this line below since CONFIG_CMD_IMLS is defined in config_cmd_default.h under ifndef condition, then I will have to undef it again.
Pls suggest??

Secondly,
I think config_cmd_default.h need be tuned for its better usability.
FLASH/FPGA/NET/SETGETDCR/IMLS are board specific, should be removed.
I know the impact will be to update all other configs which are using it.

Thirdly,
On some of Embedded systems, where memory footprint is a very critical issue, we need to bring down u-boot binary size as small as possible.
With this reference using config_cmd_default.h will be problematic.
For this I think-
 we should add one more configuration like CONFIG_SMALL_IMAGE to generate smallest image u-boot binary.
This is my requirement for some of board. 
What do you think to make it generic ? 

In brief,
I am not enjoying using this file :-(
I prefer it should be more generic.
I wish NOT to use this file, shall I ?

Regards..
Prafulla . .

> Declare no flash (NOR/SPI) */
> > > > > please move this 2
> > > > > > +
> > > > > > +#include <config_cmd_default.h> #define 
> CONFIG_CMD_AUTOSCRIPT 
> > > > > > +#define CONFIG_CMD_DHCP #define CONFIG_CMD_ENV #define 
> > > > > > +CONFIG_CMD_FAT #define CONFIG_CMD_NAND #define 
> > > > > > +CONFIG_CMD_PING #define CONFIG_CMD_USB
> > > > > here
> > > > 
> > > > Why?
> > > how this suppose to work?
> > > you undef the CMD_FLASH et redefine it from the default?
> > 
> > Good. It would be nice if you added such an explanation to your 
> > comment, so people understand why you are making such requests.
> > Otherwise they might assume you just had to make any comment.
> ok it was too obvious for me
> 
> Best Regards,
> J.
>