[U-Boot] [PATCH 1/1] Add support for Eukrea CPU9260 SBC

Wolfgang Denk wd at denx.de
Thu Jul 16 14:29:36 CEST 2009


Dear Eric Benard,

In message <1247735589-15527-1-git-send-email-eric at eukrea.com> you wrote:
> CPUAT91 is built around Atmel's AT91SAM9260 and has up to 64MB of NOR
> flash, up to 128MB of SDRAM, up to 2GB of NAND and includes a 10/100
> Ethernet PHY in RMII mode.
...
> +int dram_init(void)
> +{
> +	gd->bd->bi_dram[0].start = PHYS_SDRAM;
> +	gd->bd->bi_dram[0].size = PHYS_SDRAM_SIZE;
> +	return 0;
> +}

How about using get_ram_size() for auto-sizing and testing?

> diff --git a/cpu/arm926ejs/at91/lowlevel_init.S b/cpu/arm926ejs/at91/lowlevel_init.S
> index 5ed518c..538d3e6 100644
> --- a/cpu/arm926ejs/at91/lowlevel_init.S
> +++ b/cpu/arm926ejs/at91/lowlevel_init.S
> @@ -194,7 +194,7 @@ SMRDATA:
>  	.word CONFIG_SYS_PIOD_PPUDR_VAL
>  	.word (AT91_BASE_SYS + AT91_PIOD + PIO_ASR)
>  	.word CONFIG_SYS_PIOD_PPUDR_VAL
> -#elif defined(CONFIG_AT91SAM9261)
> +#elif defined(CONFIG_AT91SAM9261) || defined(CONFIG_AT91SAM9260)

Please swap to keep sorted:

#elif defined(CONFIG_AT91SAM9260) || defined(CONFIG_AT91SAM9261)

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Common sense and a sense of humor  are  the  same  thing,  moving  at
different speeds.  A sense of humor is just common sense, dancing.
                                                        - Clive James


More information about the U-Boot mailing list