[U-Boot] [PATCH 1/1] Add support for Eukrea CPU9260 SBC

[Eric Bénard]

Dear Wolfgang Denk,

Wolfgang Denk a écrit :
> In message <1247735589-15527-1-git-send-email-eric at eukrea.com> you wrote:
>> CPUAT91 is built around Atmel's AT91SAM9260 and has up to 64MB of NOR
>> flash, up to 128MB of SDRAM, up to 2GB of NAND and includes a 10/100
>> Ethernet PHY in RMII mode.
> ...
>> +int dram_init(void)
>> +{
>> +	gd->bd->bi_dram[0].start = PHYS_SDRAM;
>> +	gd->bd->bi_dram[0].size = PHYS_SDRAM_SIZE;
>> +	return 0;
>> +}
> 
> How about using get_ram_size() for auto-sizing and testing?
> 
the RAM needs to be properly initialized in low level before being able 
to test it so its geometry (rom/columns) and timings must be known 
before being able to detect its size using get_ram_size.
I'm not sure it's possible to use a generic geometry/timings there else 
u-boot may never relocate.
How would you do this ?

>> diff --git a/cpu/arm926ejs/at91/lowlevel_init.S b/cpu/arm926ejs/at91/lowlevel_init.S
>> index 5ed518c..538d3e6 100644
>> --- a/cpu/arm926ejs/at91/lowlevel_init.S
>> +++ b/cpu/arm926ejs/at91/lowlevel_init.S
>> @@ -194,7 +194,7 @@ SMRDATA:
>>  	.word CONFIG_SYS_PIOD_PPUDR_VAL
>>  	.word (AT91_BASE_SYS + AT91_PIOD + PIO_ASR)
>>  	.word CONFIG_SYS_PIOD_PPUDR_VAL
>> -#elif defined(CONFIG_AT91SAM9261)
>> +#elif defined(CONFIG_AT91SAM9261) || defined(CONFIG_AT91SAM9260)
> 
> Please swap to keep sorted:
> 
> #elif defined(CONFIG_AT91SAM9260) || defined(CONFIG_AT91SAM9261)
> 
OK will do.

Thanks
Eric