[U-Boot] [PATCH] Add "cpu_config" command for PPC4xx bootstrap configuration

[Wolfgang Denk]

Dear Stefan Roese,

In message <1247822763-20761-1-git-send-email-sr at denx.de> you wrote:
> From: Dirk Eibach <eibach at gdsys.de>
> 
> This patch adds a generic command for programming I2C bootstrap
> eeproms on PPC4xx. An implementation for Canyonlands board is
> included.
> 
> The command name is intentionally chosen not to be PPC4xx specific.
> This way other CPU's/SoC's can implement a similar command under
> the same name, perhaps with a different syntax.
> 
> Usage on Canyonlands:
> 
> => cpu_config
> Available configurations:
>  600-nor         - NOR  CPU: 600 PLB: 200 OPB: 100 EBC: 100
>  600-nand        - NAND CPU: 600 PLB: 200 OPB: 100 EBC: 100
>  800-nor         - NOR  CPU: 800 PLB: 200 OPB: 100 EBC: 100
>  800-nand        - NAND CPU: 800 PLB: 200 OPB: 100 EBC: 100
>  1000-nor        - NOR  CPU:1000 PLB: 200 OPB: 100 EBC: 100
>  1000-nand       - NAND CPU:1000 PLB: 200 OPB: 100 EBC: 100
>  1066-nor        - NOR  CPU:1066 PLB: 266 OPB:  88 EBC:  88
>  1066-nand       - NAND CPU:1066 PLB: 266 OPB:  88 EBC:  88

Why are the lines indented by one space?

Would it be possible to also mark the current setting in this output?
Like printing an asterisk befor or after it?

> diff --git a/board/amcc/canyonlands/cpu_config.c b/board/amcc/canyonlands/cpu_config.c
> new file mode 100644
> index 0000000..15813c4
...
> +struct ppc4xx_config ppc4xx_config_val[] = {
> +	{ "600-nor", "NOR  CPU: 600 PLB: 200 OPB: 100 EBC: 100",
> +	  {
> +		  0x86, 0x80, 0xce, 0x1f, 0x79, 0x80, 0x00, 0xa0,
> +		  0x40, 0x08, 0x23, 0x50, 0x0d, 0x05, 0x00, 0x00
> +	  } },

Indentation by TAB, please.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What is mind?  No matter.  What is matter?  Never mind.
                                      -- Thomas Hewitt Key, 1799-1875