[U-Boot] [PATCH] Add "cpu_config" command for PPC4xx bootstrap configuration

[Stefan Roese]

Hi Wolfgang,

On Friday 17 July 2009 12:45:01 Wolfgang Denk wrote:
> > => cpu_config
> > Available configurations:
> >  600-nor         - NOR  CPU: 600 PLB: 200 OPB: 100 EBC: 100
> >  600-nand        - NAND CPU: 600 PLB: 200 OPB: 100 EBC: 100
> >  800-nor         - NOR  CPU: 800 PLB: 200 OPB: 100 EBC: 100
> >  800-nand        - NAND CPU: 800 PLB: 200 OPB: 100 EBC: 100
> >  1000-nor        - NOR  CPU:1000 PLB: 200 OPB: 100 EBC: 100
> >  1000-nand       - NAND CPU:1000 PLB: 200 OPB: 100 EBC: 100
> >  1066-nor        - NOR  CPU:1066 PLB: 266 OPB:  88 EBC:  88
> >  1066-nand       - NAND CPU:1066 PLB: 266 OPB:  88 EBC:  88
>
> Why are the lines indented by one space?

It was this way in the original bootstrap version. I can remove it if you 
prefer.

> Would it be possible to also mark the current setting in this output?
> Like printing an asterisk befor or after it?

No. Currently the implementation only checks strings and has no idea of 
frequencies. Also, not only PLL frequencies are configured in this I2C 
bootstrap EEPROM but also boot-location (NOR, NAND, PCI) and other things. So 
it's really not trivial to find/search the current configuration in this 
table.

Since 4xx prints the speed's in the bootlog, it shouldn't be too hard to find 
the current setting there (if necessary).

> > +struct ppc4xx_config ppc4xx_config_val[] = {
> > +	{ "600-nor", "NOR  CPU: 600 PLB: 200 OPB: 100 EBC: 100",
> > +	  {
> > +		  0x86, 0x80, 0xce, 0x1f, 0x79, 0x80, 0x00, 0xa0,
> > +		  0x40, 0x08, 0x23, 0x50, 0x0d, 0x05, 0x00, 0x00
> > +	  } },
>
> Indentation by TAB, please.

Ups. Will fix. Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================