[U-Boot] [PATCH 1/2] update config for mvBL-M7 (MPC8343)

Wolfgang Denk wd at denx.de
Fri Jul 17 16:44:19 CEST 2009


Dear =?ISO-8859-1?Q?Andr=E9?= Schwarz,

In message <1247840636.3953.78.camel at swa-m460> you wrote:
>
> > > +#define CONFIG_MISC_INIT_R
> > 
> > So misc_init_r () gets called, but I didn;t find this in your
> > patch? May I miss something ...
>
> It's included in the other "common code" patch.

You must not break things that belong together logically into separate
patches - this would break bisectability.

If the "common code" patch adds misc_init_r(), it must also include
the config file change that makes it use this code.

Did you run MAKEALL after applying each of your patches, one by one?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Alles Gescheite ist schon gedacht worden, man muß nur versuchen,
es noch einmal zu denken.          -- Goethe, Maximen und Reflexionen


More information about the U-Boot mailing list