[U-Boot] [PATCH 1/2] update config for mvBL-M7 (MPC8343)

[André Schwarz]

On Fri, 2009-07-17 at 16:44 +0200, Wolfgang Denk wrote:
> Dear =?ISO-8859-1?Q?Andr=E9?= Schwarz,
> 
> In message <1247840636.3953.78.camel at swa-m460> you wrote:
> >
> > > > +#define CONFIG_MISC_INIT_R
> > > 
> > > So misc_init_r () gets called, but I didn;t find this in your
> > > patch? May I miss something ...
> >
> > It's included in the other "common code" patch.
> 
> You must not break things that belong together logically into separate
> patches - this would break bisectability.

yes of course.
I expected everybody to discard the patchset completely after your
rejection/comments.

The follow-up "[PATCH v2] create and use common code for Matrix Vision
boards" includes both the config and the code move in order to be
atomic/bisectable.

If there are no further objections I'll submit v3 adressing Heiko's
comments and fixing a warning due to missing #include statement.

Both board binaries compile and work as expected.


Sorry for the trouble - I'm not an everyday git user ... still trying to
improve ;-)


Regards,
André

> 
> If the "common code" patch adds misc_init_r(), it must also include
> the config file change that makes it use this code.
> 
> Did you run MAKEALL after applying each of your patches, one by one?
> 
> Best regards,
> 
> Wolfgang Denk
> 



MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschiaeftsführer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Hans-Joachim Reich