[U-Boot] [PATCH 5/6] net: Kirkwood_egiga: forced interface speed config support

[Wolfgang Denk]

Dear Ben Warren,

In message <4A655EAA.4000401 at gmail.com> you wrote:
>
> >> By default Auto Negotiation is enabled for interface speed
> >> but on some platforms like RD6281A it does not work.

What exactly is the reason that it doesn't work?

Is it some deficiency of the board hardware that always exaists, or a
problem only present in combination with certain switches. or what
exactly?


> >> If you want to forced program it to desired speed,
> >> this patch helps-
> >>
> >> Through this patch Auto negotiation can be disabled and
> >> desired interface speed can be configured

I'm not sure if it's really a good idea to do hard-code this as a
compile-time option.

> >> +#if (!defined (CONFIG_PHY_SPEED) || (CONFIG_PHY_SPEED == _1000BASET))
> >>     
> > Could you find a better config taht _1000BASET & co
> >
> >   
> Global configs for this type of thing are a bad idea (what if you want 
> one interface @ 1000 and one @ 100?  I guess this will have to do for 
> now, but let's ensure that it's temporary.

I am not convinced that such a patch should go in at all.

Foir the boards that really need such a configuration, it should be
possible to set this for example using a standard "mii" command as
part of a "preboot" environment setting.

This way the user can disable it at runtime (if he doesn;t need it),
and we don't need to change the code.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Go to Heaven for the climate, Hell for the company."    - Mark Twain