[U-Boot] [PATCH 5/6] net: Kirkwood_egiga: forced interface speed config support

[Prafulla Wadaskar]

> -----Original Message-----
> From: Ben Warren [mailto:biggerbadderben at gmail.com] 
> Sent: Tuesday, July 21, 2009 11:53 AM
> To: Jean-Christophe PLAGNIOL-VILLARD
> Cc: Prafulla Wadaskar; Manas Saksena; Ronen Shitrit; Nicolas 
> Pitre; u-boot at lists.denx.de; Ashish Karkare; Prabhanjan 
> Sarnaik; Lennert Buijtenhek
> Subject: Re: [U-Boot] [PATCH 5/6] net: Kirkwood_egiga: forced 
> interface speed config support
> 
> Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 20:58 Thu 16 Jul     , Prafulla Wadaskar wrote:
> >   
> >> By default Auto Negotiation is enabled for interface speed but on 
> >> some platforms like RD6281A it does not work.
> >> If you want to forced program it to desired speed, this 
> patch helps-
> >>
> >> Through this patch Auto negotiation can be disabled and desired 
> >> interface speed can be configured
> >>
> >> This patch is tested on RD6281A Kirkwood board
> >>
> >> Signed-off-by: Prafulla Wadaskar <prafulla at marvell.com>
> >> ---
> >>  drivers/net/kirkwood_egiga.c |   24 ++++++++++++++++++++++++
> >>  1 files changed, 24 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/drivers/net/kirkwood_egiga.c 
> >> b/drivers/net/kirkwood_egiga.c index 3c5db19..1dfd567 100644
> >> --- a/drivers/net/kirkwood_egiga.c
> >> +++ b/drivers/net/kirkwood_egiga.c
> >> @@ -415,7 +415,31 @@ static int kwgbe_init(struct eth_device *dev)
> >>  	/* Assign port configuration and command. */
> >>  	KWGBEREG_WR(regs->pxc, PRT_CFG_VAL);
> >>  	KWGBEREG_WR(regs->pxcx, PORT_CFG_EXTEND_VALUE);
> >> +	/*
> >> +	 * Forced 10/100/1000BASE-T interface speed configuration
> >> +	 * By default Auto Negotiation of interface speed is enabled
> >> +	 * This can be forced disabled and desired speed can be 
> configured
> >> +	 */
> >> +#ifdef CONFIG_DIS_AUTO_NEG_SPEED_GMII #if (!defined 
> >> +(CONFIG_PHY_SPEED) || (CONFIG_PHY_SPEED == _1000BASET))
> >>     
> > Could you find a better config taht _1000BASET & co
> >
> >   
> Global configs for this type of thing are a bad idea (what if 
> you want one interface @ 1000 and one @ 100?  I guess this 
> will have to do for now, but let's ensure that it's temporary.
I agree. I will find better way to configure this stuff.

Regards..
Prafulla ..

> 
> > Best Regards,
> > J.
> 
> regards,
> Ben
>