[U-Boot] [PATCH 1/1] Add support for Eukrea CPUAT91 SBC

[Ben Warren]

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 22:24 Wed 22 Jul     , Ben Warren wrote:
>   
>> Jean-Christophe PLAGNIOL-VILLARD wrote:
>>     
>>>>> -SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
>>>>> -OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS))
>>>>> +SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c) $(COBJS-y:.o=.c)
>>>>> +OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS) $(COBJS-y))
>>>>> all:	$(obj).depend $(LIB)
>>>>> diff --git a/cpu/arm920t/at91rm9200/ks8721.c b/cpu/arm920t/at91rm9200/ks8721.c
>>>>> new file mode 100644
>>>>> index 0000000..703e58c
>>>>> --- /dev/null
>>>>> +++ b/cpu/arm920t/at91rm9200/ks8721.c
>>>>> @@ -0,0 +1,244 @@
>>>>> +/*
>>>>> + * (C) Copyright 2006
>>>>> + * Author : Eric Benard (Eukrea Electromatique)
>>>>> + * based on dm9161.c which is :
>>>>> + * (C) Copyright 2003
>>>>> + * Author : Hamid Ikdoumi (Atmel)
>>>>>           
>>>> I'm not a fan of this implementation at all
>>>>
>>>> but as I've not yet finish the rm9200 cleanup
>>>> I'll ack this ben what do you think?
>>>> ben please note that the rm9200 cleanup will introduce a phylib support
>>>>         
>>> Ben ping
>>>
>>> Best Regards,
>>> J.
>>>       
>> This patch has many coding style violations that haven't been
>> addressed, so it can't go in.  I"m not a fan of the piece-meal PHY
>> implementation either, but realize that a real PHY lib isn't
>> imminent, unless your rm2000 implementation is useful across
>> architectures.
>>     
> it will be a generic implementation
> as we need it also for other soc and arch for our boards.
>
> Best Regards,
> J.
>   
Good.  Can't wait.

Ben