[U-Boot] [PATCH] zlib: allow 0 as destination pointer

rhabarber1848 rhabarber1848 at web.de
Wed Jul 29 08:53:59 CEST 2009


Wolfgang Denk wrote:

> Dear Giuseppe CONDORELLI,
> 
> In message <001601ca1012$e0f72730$c08182a4 at st.com> you wrote:
>> Very good!!!
>> So is it time to re-apply zlib patch to u-boot main tree, together
>> Alessandro's patch?
>> 
>> Wolfgang, what's your position?
> 
> Actually I'm waiting for a new patch that integrates that fix.

Hi,

please do not commit the zlib-1.2.3 patch in its current state, although
Alessandro's patch fixes on bug there is still the problem that the
WATCHDOG_RESET() calls from gunzip.c

#if defined(CONFIG_HW_WATCHDOG) || defined(CONFIG_WATCHDOG)
        s.outcb = (cb_func)WATCHDOG_RESET;
#else
        s.outcb = Z_NULL;
#endif<>/* CONFIG_HW_WATCHDOG */

are silently ignored in the new zlib code. My C knowledge is insufficient to
solve this problem. In its current state it will break zlib decompression
on the machines I am taking care of.

Cheers, rhabarber1848




More information about the U-Boot mailing list