[U-Boot] [PATCH] zlib: allow 0 as destination pointer
Wolfgang Denk
wd at denx.de
Wed Jul 29 09:11:51 CEST 2009
Dear rhabarber1848,
In message <h4orm0$l1d$1 at ger.gmane.org> you wrote:
>
> > Actually I'm waiting for a new patch that integrates that fix.
>
> please do not commit the zlib-1.2.3 patch in its current state, although
> Alessandro's patch fixes on bug there is still the problem that the
> WATCHDOG_RESET() calls from gunzip.c
>
> #if defined(CONFIG_HW_WATCHDOG) || defined(CONFIG_WATCHDOG)
> s.outcb = (cb_func)WATCHDOG_RESET;
> #else
> s.outcb = Z_NULL;
> #endif<>/* CONFIG_HW_WATCHDOG */
>
> are silently ignored in the new zlib code. My C knowledge is insufficient to
> solve this problem. In its current state it will break zlib decompression
> on the machines I am taking care of.
Agreed - that should be working, too, before we pull that patch into
mainline.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Perfection is reached, not when there is no longer anything to add,
but when there is no longer anything to take away.
- Antoine de Saint-Exupery
More information about the U-Boot
mailing list