[U-Boot] [RFC PATCH 1/2] sh: make lds more generic

Nobuhiro Iwamatsu iwamatsu at nigauri.org
Mon Jun 1 03:03:04 CEST 2009


Hi, Wolfgang.

2009/5/27 Wolfgang Denk <wd at denx.de>:
> Dear Nobuhiro Iwamatsu,
>
> In message <29ab51dc0905262313h17934f09u904a4e7325207148 at mail.gmail.com> you wrote:
>> 2009/5/14 Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>:
>> > currently the sh lds need to sync the lds enty and TEXT_BASE manualy
>> > and the reloc_dst is based on it
>> >
>> > instead provide it now from the ldflags
>> >
>> > tested on r2dplus
>> >
>> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
>> > Cc: Nobuhiro Iwamatsu <iwamatsu.nobuhiro at renesas.com>
>>
>> Appilied these patch collection.
>> Thank you!
>
> Sorry, but I don't agree. The commit message is terrible.
> "sh lds need to sync the lds enty" - what is that suppoosed to mean?
>
> I insist on readable and understandable commit messages.
>
OK , you are right.

Jean-Christophe, please update commit message and resend.

Best regards,
 Nobuhiro


-- 
Nobuhiro Iwamatsu


More information about the U-Boot mailing list