[U-Boot] [PATCH]
Wolfgang Denk
wd at denx.de
Mon Jun 1 09:20:36 CEST 2009
Dear "Kim, Heung Jun",
In message <b64afca20905312308r1dbe50d8pc3d04e8450483251 at mail.gmail.com> you wrote:
>
> I made new patch about L2 cane enable/disable function.
> The related thread is here.
> http://www.mail-archive.com/u-boot@lists.denx.de/msg14744.html
>
> I fixed title issue & apart header.
>
> Thanks to read :)
Your patch format has many deficiencies. I strongly recommend to use
git-format-patch to create patches for submission.
Problems:
- there is no subject, i. e. no tile line for the commit message,
- Your comments (the text above)( are part of what will become the
commit message; such comments must be placed *below* the "---" line.
- You seem to use a "=====" line as separator, but this is not used by
the git tools and does not work.
> Best Regards,
> riverful
>
> =====
> omap3 L2 cache enable/disable function moved from cpu/arm_cortexa8/cpu.c
> to cpu/arm_cortexa8/omap3/. for generic SoC supports.
>
> Signed-off-by: HeungJun, Kim <riverful.kim at samsung.com>
> ---
^^^^^^^^^^^^^^^
Please mode all your comments BELOW this line. Above is only the
commit message.
Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
More information about the U-Boot
mailing list