[U-Boot] [PATCH] The omap3 L2 cache enable/disable function to omap3 dependent code

Kim Phillips kim.phillips at freescale.com
Mon Jun 1 19:49:41 CEST 2009


On Mon, 01 Jun 2009 18:46:21 +0200
Dirk Behme <dirk.behme at googlemail.com> wrote:

> > 2. your signoff is in the correct location, however the commit message
> > is not.  It belongs above the line with the '---'.
> > 3. while making backreferences by pointing to messages in the list
> > archive is cool, they don't stand the test of time - the URL may one
> > day cease to exist.  So it is better to either reference a commitish in
> > the repository itself, or simply restate/copy the original data.
> 
> As long as references to the mailing list archive are in patch comment 
> (below --- as they are here) and don't go into git I think it's fine 
> to use them.

agreed (and I just did that myself in another thread) - it's just that,
in this case, the referenced subject matter needs to go in the git
commit message (see 2 above).

Kim


More information about the U-Boot mailing list