[U-Boot] [PATCH-ARM] Add support for Embest SBC2440-II Board

Wolfgang Denk wd at denx.de
Wed Jun 3 13:49:37 CEST 2009


Dear Kevin,

in message <4A2654CB.1020803 at fearnside-systems.co.uk> you wrote:
> 
> Although the code you've both commented on is new it uses a lot of the
> existing Samsung S3C common code in cpu/arm920t/s3c24x0 and various
> s3c24x0 drivers code. This common code also has the problems you
> commented on and additionally it doesn't meet the coding style

Yes, unfortunately we have not always been that strict in the past.

> requirements. It would probably be better for me to re-work the existing
> common code first and submit a patch, then submit a new SBC2440-II Board
> patch based on the code after the re-work patch has been applied. I'm
> happy to do this but I just have a few questions:

Thanks a lot in advance.

> - if I re-work the existing common S3C2410 code I can check the existing
> Samsung S3C boards still build but how do I make sure they still work (I
> can't test them as I only have an SBC2440-II Board)?

Such testing is supposed to be done by the respective board
maintainers.

> - once I've re-worked the existing common S3C2410 code a new patch for
> the SBC2440-II Board would only really make sense if it was based on the
> code after the common code re-work patch was applied. Is it OK to submit
> an SBC2440 Board patch that assumes the re-work patch has been applied
> first?

Yes, this is OK.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Men don't talk peace unless they're ready to back it up with war.
	-- Col. Green, "The Savage Curtain", stardate 5906.4


More information about the U-Boot mailing list