[U-Boot] [PATCH 1/3] Fix a typo in the instructions on using omap3's gpio interface.
Jean-Christophe PLAGNIOL-VILLARD
plagnioj at jcrosoft.com
Wed Jun 3 20:21:45 CEST 2009
On 20:53 Tue 02 Jun , Tom Rix wrote:
> Using the example for reading a gpio, shows the problem.
> NULL should be the gpio number.
>
> Signed-off-by: Tom Rix <Tom.Rix at windriver.com>
> ---
> doc/README.omap3 | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/doc/README.omap3 b/doc/README.omap3
> index e05e816..66e781d 100644
> --- a/doc/README.omap3
> +++ b/doc/README.omap3
> @@ -106,7 +106,7 @@ To clear a bit :
> To read a bit :
>
> if (!omap_request_gpio(N)) {
> - omap_set_gpio_direction(NULL, 1);
> + omap_set_gpio_direction(N, 1);
> val = omap_get_gpio_datain(N);
> omap_free_gpio(N);
> }
> --
> 1.6.0.5
On 20:53 Tue 02 Jun , Tom Rix wrote:
> There are currently 3 versions of the zoom2 board.
> The production board, that is currently being released.
> The beta board, similar in form to the production board but not released.
> The alpha board, a set of PCBs with a very limited circulation.
>
> GPIO 94 is used to determine the version of the board. If GPIO 94 is clear,
> the board is a production board, otherwise it is a beta board.
>
> The alpha board will likely be mistaken for a beta board. An alpha board
> was unavailible for testing.
>
> This has been tested on the beta and production boards.
>
> Signed-off-by: Tom Rix <Tom.Rix at windriver.com>
> ---
> board/omap3/zoom2/zoom2.c | 62 ++++++++++++++++++++++++++++++++++++++++++--
> board/omap3/zoom2/zoom2.h | 9 ++++++
> 2 files changed, 68 insertions(+), 3 deletions(-)
>
> diff --git a/board/omap3/zoom2/zoom2.c b/board/omap3/zoom2/zoom2.c
> index e5c248d..94231da 100644
> --- a/board/omap3/zoom2/zoom2.c
> +++ b/board/omap3/zoom2/zoom2.c
> @@ -33,6 +33,7 @@
> #include <status_led.h>
> #endif
> #include <asm/io.h>
> +#include <asm/arch/gpio.h>
> #include <asm/arch/mem.h>
> #include <asm/arch/mux.h>
> #include <asm/arch/sys_proto.h>
> @@ -60,6 +61,60 @@ static u32 gpmc_serial_TL16CP754C[GPMC_MAX_REG] = {
> 0x1D0904C4, 0
> };
>
> +/* Used to track the revision of the board */
> +static ZOOM2_REVISION zoom2_revision = ZOOM2_REVISION_UNKNOWN;
no uppercase please
if you are ok I'll remane it before apply
static zoom2_revision revision = ZOOM2_REVISION_UNKNOWN;
Best Regards,
J.
More information about the U-Boot
mailing list