[U-Boot] [PATCH 1/1] FAT replace compare_sign with strncmp.

Wolfgang Denk wd at denx.de
Thu Jun 4 23:45:14 CEST 2009


Dear Tom Rix,

In message <1242824141-32719-1-git-send-email-Tom.Rix at windriver.com> you wrote:
> The static function compare_sign is only used to compare the fs_type string
> and does not do anything more than what strncmp does.
> 
> The addition of the trailing '\0' to fs_type, while legal, is not needed
> because the it is never printed out and strncmp does not depend on NULL
> terminated strings.
> 
> Signed-off-by: Tom Rix <Tom.Rix at windriver.com>
> ---
>  fs/fat/fat.c |   36 +++---------------------------------
>  1 files changed, 3 insertions(+), 33 deletions(-)

Applied to next, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
CONSUMER NOTICE:  Because  of  the  "Uncertainty  Principle,"  It  Is
Impossible  for  the  Consumer  to  Find  Out  at  the Same Time Both
Precisely Where This Product Is and How Fast It Is Moving.


More information about the U-Boot mailing list