[U-Boot] [PATCH 2/5] 74xx_7xx: CPCI750: Add loadpci command

Stefan Roese sr at denx.de
Fri Jun 5 05:39:52 CEST 2009


Hi Matthias,

On Thursday 04 June 2009 19:40:19 Matthias Fuchs wrote:
> doen't it make sense to use/extend the code from
> board/esd/common/cmd_loadpci.c in stead it copying this code? Even that
> code is running on 4xx only, it should be simple to modify it for cpci750.
> Adding support for bootvx should be simple also.

I thought about this too but didn't do it mainly because of those reasons:

a) As you already mentioned the current code in common is 4xx specific.

b) The parameters used to identify the image type are incompatible on
   both platforms. "1" is used for booting a script on 4xx and VxWorks
   on CPCI750.

c) I have no means of testing any changes in this code on 4xx and/or
   750.

So if you still think this should be unified then I need your assistance here. 
You would need to help me testing those changes on both platforms. Please let 
me know if you can do this.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================


More information about the U-Boot mailing list