[U-Boot] [PATCH 2/2] General help message cleanup

Wolfgang Denk wd at denx.de
Fri Jun 5 11:23:31 CEST 2009


Hello,

In message <1243185450-20518-2-git-send-email-wd at denx.de> you wrote:
> Many of the help messages were not really helpful; for example, many
> commands that take no arguments would not print a correct synopsis
> line, but "No additional help available." which is not exactly wrong,
> but not helpful either.
> 
> Commit ``Make "usage" messages more helpful.'' changed this
> partially. But it also became clear that lots of "Usage" and "Help"
> messages (fields "usage" and "help" in struct cmd_tbl_s respective)
> were actually redundant.
> 
> This patch cleans this up - for example:
> 
> Before:
> 	=> help dtt
> 	dtt - Digital Thermometer and Thermostat
> 
> 	Usage:
> 	dtt         - Read temperature from digital thermometer and thermostat.
> 
> After:
> 	=> help dtt
> 	dtt - Read temperature from Digital Thermometer and Thermostat
> 
> 	Usage:
> 	dtt
> 
> Signed-off-by: Wolfgang Denk <wd at denx.de>
> ---
> Compile tested for PPC and ARM;run-time tested on a number of PPC
> boards. Image size goes down by a few hundret bytes, depending on
> configuration.
> 
> Please test carefully, as many custom bards are affected, and I did
> not have a chance to test each and every command that is enabled here
> or there.
> 
>  board/BuS/EB+MCF-EV123/EB+MCF-EV123.c         |    2 +-
>  board/ads5121/ads5121_diu.c                   |    2 +-
>  board/amcc/acadia/cmd_acadia.c                |    4 +-
>  board/amcc/canyonlands/bootstrap.c            |    4 +-
>  board/amcc/katmai/cmd_katmai.c                |    4 +-
>  board/amcc/kilauea/cmd_pll.c                  |    4 +-
>  board/amcc/luan/luan.c                        |    4 +-
>  board/amcc/makalu/cmd_pll.c                   |    4 +-
>  board/amcc/sequoia/cmd_sequoia.c              |    4 +-
>  board/amcc/taihu/lcd.c                        |   16 +++++-----
>  board/amcc/taihu/taihu.c                      |    8 ++--
>  board/amcc/taihu/update.c                     |    4 +-
>  board/amcc/taishan/lcd.c                      |   14 ++++----
>  board/amcc/taishan/showinfo.c                 |    6 ++--
>  board/amcc/taishan/update.c                   |    2 +-
>  board/amcc/yucca/cmd_yucca.c                  |    2 +-
>  board/amirix/ap1000/ap1000.c                  |   10 +++---
>  board/amirix/ap1000/powerspan.c               |    2 +-
>  board/barco/barco.c                           |    6 ++--
>  board/bc3450/cmd_bc3450.c                     |   23 +++++++------
>  board/bf537-stamp/cmd_bf537led.c              |    4 +-
>  board/cm5200/cmd_cm5200.c                     |    2 +-
>  board/delta/delta.c                           |    2 +-
>  board/esd/ar405/ar405.c                       |   13 +++----
>  board/esd/cms700/cms700.c                     |    5 ++-
>  board/esd/common/auto_update.c                |    2 +-
>  board/esd/common/cmd_loadpci.c                |    4 +-
>  board/esd/common/lcd.c                        |    2 +-
>  board/esd/common/xilinx_jtag/micro.c          |    4 +-
>  board/esd/cpci2dp/cpci2dp.c                   |    4 +-
>  board/esd/cpci405/cpci405.c                   |   12 +++---
>  board/esd/cpci5200/cpci5200.c                 |    4 ++-
>  board/esd/cpci750/cpci750.c                   |    4 +-
>  board/esd/dasa_sim/cmd_dasa_sim.c             |    2 +-
>  board/esd/du440/du440.c                       |   33 ++++++++++---------
>  board/esd/hh405/hh405.c                       |    5 ++-
>  board/esd/ocrtc/cmd_ocrtc.c                   |    4 +-
>  board/esd/pci405/cmd_pci405.c                 |    2 +-
>  board/esd/pci405/pci405.c                     |    4 +-
>  board/esd/pf5200/pf5200.c                     |   10 +++--
>  board/esd/plu405/plu405.c                     |    5 ++-
>  board/esd/pmc440/cmd_pmc440.c                 |   35 ++++++++++----------
>  board/esd/tasreg/tasreg.c                     |   24 +++++++-------
>  board/esd/voh405/voh405.c                     |    5 ++-
>  board/evb64260/zuma_pbb.c                     |    4 +--
>  board/freescale/common/pixis.c                |   28 +++++++++-------
>  board/freescale/mpc8610hpcd/mpc8610hpcd_diu.c |    4 +-
>  board/g2000/g2000.c                           |    6 ++--
>  board/hymod/bsp.c                             |    4 +-
>  board/inka4x0/inkadiag.c                      |   10 +++---
>  board/keymile/common/keymile_hdlc_enet.c      |    4 +-
>  board/lwmon/lwmon.c                           |    6 ++--
>  board/lwmon5/kbd.c                            |    2 +-
>  board/lwmon5/lwmon5.c                         |    2 +-
>  board/micronas/vct/smc_eeprom.c               |    6 ++--
>  board/mpl/mip405/cmd_mip405.c                 |    2 +-
>  board/mpl/pati/cmd_pati.c                     |    2 +-
>  board/mpl/pip405/cmd_pip405.c                 |    2 +-
>  board/mpl/vcma9/cmd_vcma9.c                   |    2 +-
>  board/pcippc2/pcippc2.c                       |    2 +-
>  board/pcs440ep/pcs440ep.c                     |    4 +-
>  board/pn62/cmd_pn62.c                         |    6 ++--
>  board/prodrive/pdnb3/pdnb3.c                  |    2 +-
>  board/pxa255_idp/pxa_idp.c                    |    2 +-
>  board/r360mpi/r360mpi.c                       |    2 +-
>  board/renesas/sh7785lcr/rtl8169_mac.c         |    4 +-
>  board/renesas/sh7785lcr/selfcheck.c           |    2 +-
>  board/renesas/sh7785lcr/sh7785lcr.c           |    2 +-
>  board/sandburst/common/ppc440gx_i2c.c         |    2 +-
>  board/sandburst/karef/karef.c                 |    4 +-
>  board/sandburst/metrobox/metrobox.c           |    4 +-
>  board/siemens/common/fpga.c                   |    2 +-
>  board/siemens/pcu_e/pcu_e.c                   |    8 ++--
>  board/ssv/common/cmd_sled.c                   |    2 +-
>  board/ssv/common/wd_pio.c                     |    2 +-
>  board/tqc/tqm5200/cmd_stk52xx.c               |   13 ++++---
>  board/tqc/tqm5200/cmd_tb5200.c                |    4 +-
>  board/tqc/tqm8272/tqm8272.c                   |    2 +-
>  board/trab/cmd_trab.c                         |   12 +++---
>  board/trab/trab.c                             |    2 +-
>  board/trizepsiv/eeprom.c                      |    3 +-
>  board/w7o/cmd_vpd.c                           |    2 +-
>  board/zeus/update.c                           |    2 +-
>  board/zeus/zeus.c                             |    4 +-
>  common/cmd_ambapp.c                           |    7 ++--
>  common/cmd_bdinfo.c                           |    2 +-
>  common/cmd_bedbug.c                           |   16 +++++-----
>  common/cmd_bmp.c                              |    2 +-
>  common/cmd_boot.c                             |    4 +-
>  common/cmd_bootldr.c                          |    3 +-
>  common/cmd_bootm.c                            |   10 +++---
>  common/cmd_cache.c                            |    4 +-
>  common/cmd_cplbinfo.c                         |    4 +-
>  common/cmd_dataflash_mmc_mux.c                |    2 +-
>  common/cmd_date.c                             |    2 +-
>  common/cmd_dcr.c                              |    8 ++--
>  common/cmd_df.c                               |    2 +-
>  common/cmd_diag.c                             |    2 +-
>  common/cmd_display.c                          |    2 +-
>  common/cmd_doc.c                              |    4 +-
>  common/cmd_dtt.c                              |    4 +-
>  common/cmd_eeprom.c                           |    4 +-
>  common/cmd_elf.c                              |    4 +-
>  common/cmd_ext2.c                             |    4 +-
>  common/cmd_fat.c                              |    6 ++--
>  common/cmd_fdc.c                              |    2 +-
>  common/cmd_fdos.c                             |    4 +-
>  common/cmd_fdt.c                              |    2 +-
>  common/cmd_flash.c                            |    6 ++--
>  common/cmd_fpga.c                             |    5 ++-
>  common/cmd_i2c.c                              |   30 +++++++++---------
>  common/cmd_ide.c                              |    4 +-
>  common/cmd_immap.c                            |   33 +++++++++----------
>  common/cmd_irq.c                              |    3 +-
>  common/cmd_itest.c                            |    2 +-
>  common/cmd_jffs2.c                            |    7 ++--
>  common/cmd_license.c                          |    5 ++-
>  common/cmd_load.c                             |   16 +++++-----
>  common/cmd_log.c                              |    2 +-
>  common/cmd_mac.c                              |   18 +---------
>  common/cmd_mem.c                              |   37 ++++++++++-----------
>  common/cmd_mfsl.c                             |    7 ++--
>  common/cmd_mgdisk.c                           |    2 +-
>  common/cmd_mii.c                              |    2 +-
>  common/cmd_misc.c                             |    4 +-
>  common/cmd_mmc.c                              |   10 +++--
>  common/cmd_mp.c                               |    7 ++--
>  common/cmd_mtdparts.c                         |    4 +-
>  common/cmd_nand.c                             |   43 +++++++++++++------------
>  common/cmd_net.c                              |   12 +++---
>  common/cmd_nvedit.c                           |   10 +++---
>  common/cmd_onenand.c                          |    2 +-
>  common/cmd_otp.c                              |    3 +-
>  common/cmd_pci.c                              |    2 +-
>  common/cmd_pcmcia.c                           |    4 +-
>  common/cmd_portio.c                           |    4 +-
>  common/cmd_reginfo.c                          |    1 +
>  common/cmd_reiser.c                           |    4 +-
>  common/cmd_sata.c                             |    3 +-
>  common/cmd_scsi.c                             |    4 +-
>  common/cmd_setexpr.c                          |    2 +-
>  common/cmd_sf.c                               |    3 +-
>  common/cmd_source.c                           |    7 ++--
>  common/cmd_spi.c                              |    2 +-
>  common/cmd_strings.c                          |    3 +-
>  common/cmd_ubi.c                              |    2 +-
>  common/cmd_ubifs.c                            |   17 ++++++----
>  common/cmd_universe.c                         |    2 +-
>  common/cmd_usb.c                              |    6 ++--
>  common/cmd_vfd.c                              |    2 +-
>  common/cmd_ximg.c                             |   11 +++---
>  common/cmd_yaffs2.c                           |   24 +++++++-------
>  common/command.c                              |   15 ++++-----
>  common/hush.c                                 |    2 +-
>  common/lcd.c                                  |    2 +-
>  cpu/arm_cortexa8/omap3/board.c                |    4 +-
>  cpu/mpc512x/iim.c                             |    4 +-
>  cpu/mpc512x/speed.c                           |    2 +-
>  cpu/mpc83xx/speed.c                           |    2 +-
>  cpu/nios/asmi.c                               |    2 +-
>  cpu/nios2/epcs.c                              |    2 +-
>  cpu/nios2/sysid.c                             |    2 +-
>  drivers/gpio/pca953x.c                        |    2 +-
>  drivers/misc/ds4510.c                         |    8 +++--
>  drivers/qe/qe.c                               |    5 ++-
>  165 files changed, 519 insertions(+), 508 deletions(-)

Applied to next.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You speak of courage. Obviously you do not know the  difference  bet-
ween  courage and foolhardiness. Always it is the brave ones who die,
the soldiers.
	-- Kor, the Klingon Commander, "Errand of Mercy",
	   stardate 3201.7


More information about the U-Boot mailing list