[U-Boot] TSEC ethernet controller problems (crc errors/ corruption)

[Paul Gortmaker]

Paul Gortmaker wrote:
> Kim Phillips wrote:
>> On Wed, 3 Jun 2009 10:50:25 -0700
>> Ira Snyder <iws at ovro.caltech.edu> wrote:
> 
> ...
> 
>>>
>>> In practice, this doesn't seem to make a difference on the MPC8349EMDS
>>> eval board. Both settings work without any errors. For people like me,
>>> who are copying an existing board port to a similar board, it would be
>>> nice if it was correct.
>>
>> granted.  I'm betting the sbc8349 and tqm834x just copied the setting
> 
> You would be correct (at least for the sbc).
> 
>> from the MDS code, so those should get 0 too.  Board maintainers,
>> please test:
> 
> I won't be able to test this on an sbc until later this week,
> but don't let that stop you from queueing it up; I suspect it
> will just be a formality.

I applied the chunk below onto a checkout of v2009.06-rc2 and it
works fine on sbc8349; tested both TSEC and at both 100 and 1GB.

Tested-by: Paul Gortmaker <paul.gortmaker at windriver.com>


-------
U-Boot 2009.06-rc2-dirty (Jun 05 2009 - 14:11:18) MPC83XX                       
                                                                                
Reset Status: Software Hard, External/Internal Soft, External/Internal Hard     
                                                                                
CPU:   e300c1, MPC8349E, Rev: 1.1 at 396 MHz, CSB: 264 MHz                      
Board: Wind River SBC834x                                                       
I2C:   ready                                                                    
DRAM:     SDRAM on Local Bus: Disabled in config                                
256 MB (DDR1, 64-bit, ECC off, 264 MHz)                                         
FLASH:  8 MB                                                                    
In:    serial                                                                   
Out:   serial                                                                   
Err:   serial                                                                   
Net:   TSEC0, TSEC1                                                             
=> 
-------



> 
> Thanks,
> Paul.
> 
> 
>> diff --git a/include/configs/sbc8349.h b/include/configs/sbc8349.h
>> index d0338f1..edd928d 100644
>> --- a/include/configs/sbc8349.h
>> +++ b/include/configs/sbc8349.h
>> @@ -519,7 +519,7 @@
>>  #endif
>>  
>>  /* System IO Config */
>> -#define CONFIG_SYS_SICRH SICRH_TSOBI1
>> +#define CONFIG_SYS_SICRH 0
>>  #define CONFIG_SYS_SICRL SICRL_LDP_A
>>  
>>  #define CONFIG_SYS_HID0_INIT   0x000000000
>>
>> Thanks,
>>
>> Kim
> 
>