[U-Boot] [PATCH] mpc512x: Fix problem with I2C access before relocation

[Stefan Roese]

On Monday 08 June 2009 12:33:01 Heiko Schocher wrote:
> >> This is needed for the upcoming esd MECP5123 board port which uses I2C
> >> EEPROM for environment storage.
> >
> > Stefan, please  check  if  this  is  really  what  you  want  to  do.
> > Environmentin EEPROM is *strongly* discouraged. It is slow like hell,
> > and  even more unreliable. Do *not* do this. Check if you can use any
> > other storage - NOR or NAND flash, or the like.
> >
> >> Signed-off-by: Stefan Roese <sr at denx.de>
> >> Cc: Reinhard Arlt <reinhard.arlt at esd-electronics.com>
> >> ---
> >>  cpu/mpc512x/i2c.c |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > Heiko, if Stefan does not change his mind, then I suggest you ACK the
> > patch and I apply it then to the 5xxx repo?
>
> This Patch is okay, independent if Stefan changes his mind or
> not, I think. Thanks to Stefan for finding this.

Full ACK. This is a bugfix and should be applied in any case.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================