[U-Boot] [PATCH 1/1] usb: fix wait_ms declaration

[Remy Bohmer]

Hi,

2009/6/7 Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>:
> global inline function need to be define in a header

Agreed, but I have a few small remarks below

> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> ---
>  common/usb.c  |   10 ----------
>  include/usb.h |    6 ++++++
>  2 files changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/include/usb.h b/include/usb.h
> index 7c47098..a181e0e 100644
> --- a/include/usb.h
> +++ b/include/usb.h
> @@ -242,6 +242,12 @@ int usb_get_configuration_no(struct usb_device *dev, unsigned char *buffer,
>                                int cfgno);
>  int usb_get_report(struct usb_device *dev, int ifnum, unsigned char type,
>                        unsigned char id, void *buf, int size);
> +static void __inline__ wait_ms(unsigned long ms)

Please, remove the definition at line 240 as well (inline void
wait_ms(unsigned long ms);)
But, is there not another header better suited for a generic timer
wait routine? It should not be USB specific. (Maybe common.h?)

Kind Regards,

Remy