[U-Boot] [PATCH v2 1/3] mpc52xx: Add SPI driver.

[Wolfgang Denk]

Dear Grzegorz Bernacki,

In message <4A2FAC29.2000304 at semihalf.com> you wrote:
>
> Declaration of out8() is in common.h file:
> void		out8(unsigned int, unsigned char);
> so I think that this cast is necessary.
> 
> Without it I get warning:
> mpc52xx_spi.c:38: warning: passing argument 1 of 'out8' makes integer
> from pointer without a cast

This should make you think if out8() is the correct accessor macro to
use on a PowerPC system.

Given the fact that U-Boot has not adapted ioread*() / iowrite*() yet,
you should better use out_8() instead (see asm/io.h).

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"A dirty mind is a joy forever."                       - Randy Kunkee