[U-Boot] [PATCH 3/4] ZOOM2 Add power reset button

[Heiko Schocher]

Hello Menon,

Menon, Nishanth wrote:
>> -----Original Message-----
>> From: Dirk Behme [mailto:dirk.behme at googlemail.com]
>> Sent: Wednesday, June 10, 2009 10:44 AM
>>>>> --- a/drivers/i2c/twl4030_i2c.c
>>>> All other drivers in drivers/i2c are host adapter drivers.  Ie they
>>>> implement i2c_read(), i2c_write(), i2c_probe(), and i2c_init().  The
>>>> twl4030_i2c.c driver doesn't seem to fit this mold.  Perhaps it would
>> be
>>>> better placed in drivers/misc or a new drivers/power directory similar
>>>> to Linux?
>>> This function probably belongs to board/omap3/common/power.c -> or even
>> better to the board file itself?
>>
>> I was about to mention the opposite ;)
>>
>> Jean-Christophe asked to move the code from power.c to driver directory
>>
>> http://lists.denx.de/pipermail/u-boot/2009-May/052400.html
>>
>> If you follow above discussion, I was fine with power.c. If we get now
>> a twl4030_i2c.c, we should merge the code from power.c into it, too
>> (where ever it will be located and named, then).
>>
> This IMHO is the right approach -> but the real question is where in drivers/ directory? How about drivers/i2c/chips and moving the current drivers/i2c/* to drivers/i2c/busses - following the kernel organization?

No, I vote for moving this driver in a "drivers/power" directory.

BTW: Can you please use a linelength <80 characters? Thanks.

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany