[U-Boot] 83xx 85xx: UEC: Implicit declaration of function 'uec_standard_init'

[Kumar Gala]

On Jun 16, 2009, at 3:50 PM, Richard Retanubun wrote:

> [snip]
>> How about removing the  include "netdev.h" and adding:
>>
>> extern int uec_standard_init(bd_t *bis);
>>
> D'oh!
>
> diff --git a/cpu/mpc83xx/cpu.c b/cpu/mpc83xx/cpu.c
> index c4331ae..f29b848 100644
> --- a/cpu/mpc83xx/cpu.c
> +++ b/cpu/mpc83xx/cpu.c
> @@ -33,13 +33,14 @@
>  #include <asm/processor.h>
>  #include <libfdt.h>
>  #include <tsec.h>
> -#include <netdev.h>
>  #include <fsl_esdhc.h>
>  #ifdef CONFIG_BOOTCOUNT_LIMIT
>  #include <asm/immap_qe.h>
>  #include <asm/io.h>
>  #endif
>
> +extern int uec_standard_init(bd_t *bis);
> +
>  DECLARE_GLOBAL_DATA_PTR;
>
>  int checkcpu(void)
>
>
> Yeah, this works (if we want to patch it, better do it for the cpu/ 
> mpc85xx/cpu.c also though) :)
>
>> IMHO this submission should be backed out - it looks like it wasn't  
>> properly baked.
>
> I'll let you make the call on that, the patch does introduce a nice  
> cleanup on a
> problem I've compounded in the past so I am quite grateful for it.

I've posted a patch which I think address the issue.

- k