[U-Boot] [PATCH-ARM 2/2] Add support for the Embest SBC2440-II Board

[Wolfgang Denk]

Dear "kevin.morfitt at fearnside-systems.co.uk",

In message <4A3BC007.4060000 at fearnside-systems.co.uk> you wrote:
> This is the second of two patches that will add support for the Embest 
> SBC2440-II Board. This one adds the new code for the Embest SBC2440-II Board. 
> Tested on an Embest SBC2440-II Board with u-boot in NOR flash, using tftp to 
> copy kernel and root file system images from a tftp server, programming them 
> into NAND flash and ensuring the kernel boots correctly at re-start. Also, 
> MAKEALL was run for all ARM9 boards and no new warnings or errors were found.
> 
> Signed-off-by: Kevin Morfitt <kevin.morfitt at fearnside-systems.co.uk>
...
> diff --git a/board/embest/sbc2440ii/lowlevel_init.S b/board/embest/sbc2440ii/lowlevel_init.S
> new file mode 100644
> index 0000000..697c2a2
> --- /dev/null
> +++ b/board/embest/sbc2440ii/lowlevel_init.S
> @@ -0,0 +1,219 @@
...
> +_TEXT_BASE:
> +  .word TEXT_BASE
> +
> +.globl lowlevel_init
> +lowlevel_init:
> +  /* memory control configuration */
> +  /* make r0 relative the current location so that it */
> +  /* reads SMRDATA out of FLASH rather than memory ! */
> +  ldr     r0, =SMRDATA
> +  ldr   r1, _TEXT_BASE
> +  sub   r0, r0, r1
> +  ldr   r1, =BWSCON /* Bus Width Status Controller */
> +  add     r2, r0, #13*4
> +0:
> +  ldr     r3, [r0], #4
> +  str     r3, [r1], #4
> +  cmp     r2, r0
> +  bne     0b
> +
> +  /* everything is fine now */
> +  mov   pc, lr

Indentation by TAB, please.

> diff --git a/include/configs/sbc2440ii.h b/include/configs/sbc2440ii.h
> new file mode 100644
> index 0000000..26ad15d
> --- /dev/null
> +++ b/include/configs/sbc2440ii.h
...
> +/*
> + * select serial console configuration
> + */
> +#define CONFIG_S3C24X0_SERIAL
> +#define CONFIG_SERIAL1	1	/* we use SERIAL 1 on SBC2440-II */
> +
> +/************************************************************
> + * RTC
> + ************************************************************/
> +#define CONFIG_RTC_S3C24X0	1
> +
> +/* allow to overwrite serial and ethaddr */
> +#define CONFIG_ENV_OVERWRITE
> +
> +#define CONFIG_BAUDRATE	115200
> +
> +

You may want to sort this file a bit; I wouyld expect to find
CONFIG_BAUDRATE in the "serial console configuration" section, not in
"RTC", etc.

Also, please avoid these multiple empty lines when they don't really
make sense (like here).

> +/*
> + * BOOTP options
> + */
> +#define CONFIG_BOOTP_BOOTFILESIZE
> +#define CONFIG_BOOTP_BOOTPATH
> +#define CONFIG_BOOTP_GATEWAY
> +#define CONFIG_BOOTP_HOSTNAME
> +
> +
> +/*

... or here.

> +#define CONFIG_LOADADDR		30008000
> +/*#define CONFIG_BOOTFILE	"elinos-lart" */

Please do not add dead code.

> +#define CONFIG_BOOTCOMMAND	"nboot 30008000 0 0"
> +/*#define CONFIG_NFSBOOTCOMMAND	NFS_BOOTARGS*/

Please do not add dead code.

> +/* the PWM TImer 4 uses a counter of 15625 for 10 ms, so we need */
> +/* it to wrap 100 times (total 1562500) to get 1 sec. */
> +#define CONFIG_SYS_HZ	1562500

CONFIG_SYS_HZ *must* be set to 1000.


Full NAK because of that.

Please fix and resubmit.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Wenn Du ein' weise Antwort verlangst, Mußt Du vernünftig fragen.
                                                -- Goethe, Invektiven