[U-Boot] [PATCH] mtd: Update MTD infrastructure to support 64bit device size
Dirk Behme
dirk.behme at googlemail.com
Mon Jun 22 22:04:05 CEST 2009
Scott Wood wrote:
> Dirk Behme wrote:
>> What I still miss: If this warning indicates that something *is*
>> wrong, why not run MAKEALL and enable it in config for all boards that
>> show this warning? What's the advantage of having all maintainers
>> sending patches for their boards?
>
> 1. That requires having all toolchains installed, and
Hmm? In nand_util.c we have
#if !defined(CONFIG_SYS_64BIT_VSPRINTF)
#warning Please define CONFIG_SYS_64BIT_VSPRINTF for correct output!
#endif
and in Makefile we have
ifdef CONFIG_CMD_NAND
ifndef CONFIG_NAND_LEGACY
...
COBJS-y += nand_util.o
endif
So I would assume that this warning appears for all boards having
CONFIG_CMD_NAND enabled and no CONFIG_NAND_LEGACY and no
CONFIG_SYS_64BIT_VSPRINTF? Independent of tool chain?
> 2. That does nothing to prevent future boards from being added that are
> missing the dependency.
Ok, for future boards this warning is fine. But I talk about all the
existing boards.
Best regards
Dirk
More information about the U-Boot
mailing list