[U-Boot] [PATCH 2/2 v4] KB9202: Add NAND support

[Scott Wood]

On Thu, Jun 11, 2009 at 08:46:54PM +0200, Matthias Kaehlcke wrote:
> Add NAND support for the KwikByte KB9202
> 
> Signed-off-by: Matthias Kaehlcke <matthias at kaehlcke.net>
> 
> --

The git separator is three dashes, not two.

> Changes:
> 
> - moved driver to drivers/mtd/nand/
> - use i/o accessors
> - don't check for ATL custom board
> - removed unnecessary cast
> - don't use magic numbers
> 
>  drivers/mtd/nand/Makefile                    |    1 +
>  drivers/mtd/nand/kb9202_nand.c               |  151 ++++++++++++++++++++++++++
>  include/asm-arm/arch-at91rm9200/AT91RM9200.h |    2 +
>  include/configs/kb9202.h                     |   11 ++-

I get conflicts in kb9202.h.  Is this against an arch tree, or does it
need to be respun?

> diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile
> index 471cd6b..d2f3e61 100644
> --- a/drivers/mtd/nand/Makefile
> +++ b/drivers/mtd/nand/Makefile
> @@ -44,6 +44,7 @@ COBJS-$(CONFIG_NAND_NOMADIK) += nomadik.o
>  COBJS-$(CONFIG_NAND_S3C2410) += s3c2410_nand.c
>  COBJS-$(CONFIG_NAND_S3C64XX) += s3c64xx.o
>  COBJS-$(CONFIG_NAND_OMAP_GPMC) += omap_gpmc.o
> +COBJS-$(CONFIG_NAND_KB9202) += kb9202_nand.o

Wolfgang likes these things kept in alphabetical order.

> +int board_nand_init(struct nand_chip *nand)
> +{
> +	unsigned int value;
> +
> +	nand->ecc.mode = NAND_ECC_SOFT;
> +	nand->options &= ~NAND_BUSWIDTH_16;

Why would you need to clear this?  It's the board driver that sets it in
the first place (if applicable).

> +	/* setup nand flash access (allow ample margin) */
> +	/* 4 wait states, 1 setup, 1 hold, 1 float for 8-bit device */
> +	writel(AT91C_SMC2_WSEN | KB9202_SMC2_NWS | KB9202_SMC2_TDF |
> +				 AT91C_SMC2_DBW_8 | KB9202_SMC2_RWSETUP | KB9202_SMC2_RWHOLD,
> +				 AT91C_SMC_CSR3);
> +

Line length.  Did you perhaps use a tab size other than 8?

Otherwise, ACK.

-Scott