[U-Boot] [PATCH 1/3] fix: missing autoconfig.mk from general Makefile

[Jean-Christophe PLAGNIOL-VILLARD]

On 00:40 Wed 24 Jun     , Shinya Kuribayashi wrote:
> Jean-Christophe PLAGNIOL-VILLARD wrote:
> >> | ifneq (,$(CONFIG_CPU_LITTLE_ENDIAN))
> >> | PLATFORM_CPPFLAGS	+= $(shell $(CC) -dumpmachine |...
> >> | else
> >> | PLATFORM_CPPFLAGS	+= $(shell $(CC) -dumpmachine |...
> >> | endif
> >> |
> >> | PLATFORM_LDFLAGS	+= -EL
> >>
> >> does work.
> > ???
> > you compile it as big endian to link it as little ???
> 
> Ah, above was just a sample only intended for LE build.
> 
> >> Then, what needs to be fixed finally?  Can't we have PLATFORM_LDFLAGS
> >> conditionally configured?  or is this a U-Boot's build system issue?
> > it a u-boot build system issues
> > we need to include the autoconf.mk after generate it to use it in the GENERAL
> > Makefile which is the case here for final link
> 
> I know that, but $(obj)include/autoconf.mk will be included by
> $(TOPDIR)/config.mk.  Then what a rationale for including it redundantly
> by $(TOPDIR/Makefile?  I assume that Wolfgang is probably requesting the
> explanation for that.
for sub Makefile yes as you re-include it via including config.mk
for the first Makefile no as you generate it in you need to include it just
after to be able to use it as you include the config.mk before generate it
> 
> Autoconf.mk is expected to be generated *before* $(TOPDIR)/config.mk is
> included, right?
no not in the general Makefile

Best Regards,
J.